nilsjohan/recipe-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: replace ListView with SingleChildScrollView for better layout in admin panels
Test Suite / test (24.15.0) (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Nils-Johan Gynther
2026-05-08 16:31:09 +02:00
parent a5273158e2
commit e3bbd7d99e
4 changed files with 55 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
flutter/lib/features/admin/presentation/admin_aliases_panel.dart
+10 -7
View File
@@ -296,13 +296,16 @@ class _AdminAliasesPanelState extends ConsumerState<AdminAliasesPanel> {
if (filteredAliases.isEmpty) return content; if (filteredAliases.isEmpty) return content;
return Column( return SingleChildScrollView(
crossAxisAlignment: CrossAxisAlignment.start, padding: const EdgeInsets.all(12),
children: [ child: Column(
content, crossAxisAlignment: CrossAxisAlignment.start,
const SizedBox(height: 8), children: [
Expanded(child: buildAliasList()), content,
], const SizedBox(height: 8),
...filteredAliases.map(buildAliasCard),
],
),
); );
} }
} }
flutter/lib/features/admin/presentation/admin_pending_products_panel.dart
+13 -10
View File
@@ -140,16 +140,19 @@ class _AdminPendingProductsPanelState
if (!widget.embedded) return content; if (!widget.embedded) return content;
return Column( return SingleChildScrollView(
crossAxisAlignment: CrossAxisAlignment.start, padding: const EdgeInsets.all(12),
children: [ child: Column(
Text( crossAxisAlignment: CrossAxisAlignment.start,
context.l10n.adminPendingDescription, children: [
style: theme.textTheme.bodyMedium, Text(
), context.l10n.adminPendingDescription,
const SizedBox(height: 12), style: theme.textTheme.bodyMedium,
Expanded(child: content), ),
], const SizedBox(height: 12),
content,
],
),
); );
} }
} }
flutter/lib/features/admin/presentation/admin_products_panel.dart
+3 -3
View File
@@ -738,9 +738,9 @@ class _AdminProductsPanelState extends ConsumerState<AdminProductsPanel> {
); );
} }
return ListView( return SingleChildScrollView(
padding: EdgeInsets.zero, padding: const EdgeInsets.all(12),
children: [content], child: content,
); );
} }
} }
flutter/lib/features/admin/presentation/admin_users_panel.dart
+29 -26
View File
@@ -349,33 +349,36 @@ class _AdminUsersPanelState extends ConsumerState<AdminUsersPanel> {
return list; return list;
} }
return Column( return SingleChildScrollView(
crossAxisAlignment: CrossAxisAlignment.start, padding: const EdgeInsets.all(12),
children: [ child: Column(
Row( crossAxisAlignment: CrossAxisAlignment.start,
children: [ children: [
Expanded( Row(
child: Text( children: [
context.l10n.adminUsersDescription, Expanded(
style: theme.textTheme.bodyMedium, child: Text(
context.l10n.adminUsersDescription,
style: theme.textTheme.bodyMedium,
),
), ),
), IconButton(
IconButton( icon: const Icon(Icons.refresh),
icon: const Icon(Icons.refresh), tooltip: 'Uppdatera',
tooltip: 'Uppdatera', onPressed: _load,
onPressed: _load, ),
), ],
], ),
), const SizedBox(height: 8),
const SizedBox(height: 8), FilledButton.icon(
FilledButton.icon( onPressed: _createUser,
onPressed: _createUser, icon: const Icon(Icons.person_add_outlined),
icon: const Icon(Icons.person_add_outlined), label: Text(context.l10n.adminNewUser),
label: Text(context.l10n.adminNewUser), ),
), const SizedBox(height: 16),
const SizedBox(height: 16), list,
Expanded(child: list), ],
], ),
); );
} }
} }